Use link-style button in editable table and Form.Table improvements #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddie927
approved these changes
Jun 22, 2020
maddie927
reviewed
Jun 22, 2020
arthurxavierx
force-pushed
the
arthur/editable-table
branch
2 times, most recently
from
b156eba to
ba368a9
Compare
arthurxavierx
force-pushed
the
arthur/editable-table
branch
from
7212cc8 to
0e5fe1a
Compare
arthurxavierx
changed the title
hdgarrood
approved these changes
Jun 23, 2020
| -- | A `TableFormBuilder` makes a `FormBuilder` for an array where each row has | ||
| -- | columns defined by it. | ||
| editableTable | ||
| :: forall props row result | ||
| . { addLabel :: String | ||
| , defaultValue :: Maybe row | ||
| , addRow :: Maybe (Aff (Maybe row)) |
There was a problem hiding this comment.
I think this could do with a comment to say what the meaning of each Maybe is. I guess the outer maybe tells the component whether to render the "Add row" link at all, and the inner one allows you to decide whether or not to actually add the row when the link is clicked?
There was a problem hiding this comment.
Good point, I'll add a docstring here. Yes, that's exactly what those types mean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains breaking changes.
Form.Tablevia a newrowMenupropForm.TablesummaryinForm.Table