Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove note about specific effect type #24

Merged
merged 2 commits into from
Oct 1, 2020
Merged

Remove note about specific effect type #24

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e41e5f
Remove note about specific effect type
maxdeviant Oct 1, 2020
2286257
Simplify wording
maxdeviant Oct 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Data/JSDate.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,8 @@ foreign import dateMethod :: forall a. Fn2 String JSDate a
-- | behaviour for a given string. The RFC2822 and ISO8601 date string formats
-- | should parse consistently.
-- |
-- | The `LOCALE` effect is present here as if no time zone is specified in the
-- | string the current locale's time zone will be used instead.
-- | This function is effectful in the sense that if no time zone is specified
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "in the sense that" can be shortened to "because" here

-- | in the string the current locale's time zone will be used instead.
foreign import parse :: String -> Effect JSDate

-- | Gets a `JSDate` value for the date and time according to the current
Expand Down