strange safe_directory behavior

[krissik]

Describe the Bug

I have set safe_directory => True.
If I run puppet it is set as expected but on the next run it is unset again. On another server the directory is always append to .gitconfig so /root/.gitconfig looks like that

[safe]
        directory = /opt/myrepo
        directory = /opt/myrepo
        directory = /opt/myrepo

Expected Behavior

Directory of repository is added to "safe" paragraph at .gitconfig if it is not present and not removed.

Steps to Reproduce

This is how I use vcsrepo

 vcsrepo { $deployment_dir:
        ensure         => latest,
        provider       => git,
        safe_directory => true,
        source         => $buildout_repo,
        revision       => $repo_deployment_branch,
        owner          => $buildout_user,
        group          => $buildout_user,
        excludes       => ['parts', 'bin'],
    }

Environment

• Version 5.3.0
• Platform Debian 10

[krissik]

Despite poor ruby knowledge I guess that the case "directory is already in safe_directory list" is missing at

https://github.com/puppetlabs/puppetlabs-vcsrepo/blob/main/lib/puppet/provider/vcsrepo/git.rb#L630

b/c should_add_save_directory returns false if directory is already in safe_directory list and so remove_safe_directory is called.

[david22swan]

Fix for this is up: #605

[david22swan]

Release with fix for this has gone out: v6.0.1
Feel free to reopen if it persists