(MODULES-7768) Handle nil in delete_undef_values() function #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlindberg
force-pushed
the
MODULES-7768_fix-undef-vs-nil
branch
from
9809c23 to
f887468
Compare
PUP-9112 changed use of `:undef` inside structured values to instead using `nil` in Puppet 6.0.0. The `delete_undef_values()` function was not prepared to handle this and would not delete `nil` from `Array` or `Hash` values. This commit fixes this problem.
hlindberg
force-pushed
the
MODULES-7768_fix-undef-vs-nil
branch
from
f887468 to
792bcd4
Compare
|
|
MikaelSmith
approved these changes
Sep 10, 2018
tohuwabohu
added a commit
to tohuwabohu/puppet-duplicity
that referenced
this pull request
Sep 23, 2018
Work around broken delete_undef_values() function which doesn't handle undef values on Puppet 6 anymore (see https://github .com/puppetlabs/puppetlabs-stdlib/pull/954).
|
Hey @hlindberg / @MikaelSmith - the Modules team should really be involved in these changes to stdlib as maintainers of the repo - we have no visibility of the changes, or had a chance to review and feedback - esp around any related changes to acceptance or unit tests that may be needed to prevent the module going red in our pipelines |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PUP-9112 changed use of
:undefinside structured values to insteadusing
nilin Puppet 6.0.0. Thedelete_undef_values()functionwas not prepared to handle this and would not delete
nilfromArrayorHashvalues.This commit fixes this problem.
All 3.x functions in stdlib were reviewed for the same problem, and only
delete_undef_values()had this problem.