add Function extname() #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlindberg
suggested changes
Sep 9, 2018
| # | ||
| # extname.rb | ||
| # | ||
| module Puppet::Parser::Functions |
There was a problem hiding this comment.
Please implement using the 4.x function API and namespace the function to stdlib
There was a problem hiding this comment.
Thanks for Your Review.
I changed the Function to using Puppet-4-Function-API now.
hlindberg
previously requested changes
Sep 14, 2018
lib/puppet/functions/extname.rb
Outdated
| # An empty String will also be returned, when the Period is the last Character | ||
| # in Path. | ||
|
|
||
| Puppet::Functions.create_function(:extname) do |
There was a problem hiding this comment.
please make that :'stdlib::extname' to place it in the stdlib namespace.
Then, the examples need to be updated to use stdlib::extname(...)
There was a problem hiding this comment.
Done.
Also I moved it into functions/stdlib/ according to the Documentation.
I adapted also README.md, although this one might be auto-generated.
hlindberg
dismissed
their stale review
My concern is addressed - the maintainers of stdlib can decide if they want this function or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.