Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMF service instance change in Oracle Solaris 11.4 SRU 45.119.2 #647

Merged
merged 1 commit into from
Aug 26, 2022
Merged

SMF service instance change in Oracle Solaris 11.4 SRU 45.119.2 #647

merged 1 commit into from
Aug 26, 2022

Conversation

Kristijan
Copy link
Contributor

Oracle Solaris 11.4 SRU 45.119.2 adds a new SMF service for NTP monitoring svc:/network/ntp:monitor.

This results in the ntp module failing with the following error:

Error: /Stage[main]/Ntp::Service/Service[ntp]: Could not evaluate: Failed to get the FMRI of the network/ntp service: The pattern 'network/ntp' matches multiple FMRIs! These are the FMRIs it matches: svc:/network/ntp:default, svc:/network/ntp:monitor

This change updates ntp::service_name to specifically reference the default instance.

@Kristijan Kristijan requested a review from a team as a code owner June 15, 2022 07:12
@CLAassistant
Copy link

CLAassistant commented Jun 15, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

Hello! 👋

This pull request has been open for a while and has had no recent activity. We've labelled it with attention-needed so that we can get a clear view of which PRs need our attention.

If you are waiting on a response from us we will try and address your comments on a future Community Day.

Alternatively, if it is no longer relevant to you please close the PR with a comment.

Please note that if a pull request receives no update for 7 after it has been labelled, it will be closed. We are always happy to re-open pull request if they have been closed in error.

Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested (not running this OS) but seems legit.

Fixes #645

@smortex smortex linked an issue Aug 22, 2022 that may be closed by this pull request
@pmcmaw
Copy link
Contributor

pmcmaw commented Aug 26, 2022

Thanks for this @Kristijan :-)

@pmcmaw pmcmaw merged commit ba73538 into puppetlabs:main Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solaris 11 service name matches multiple FRMIs
6 participants