(#10846) add spec tests for ntp class

[bodepd]

This commit adds some unit tests for the
ntp class.

[kbarber]

Is it just me - or are you writing squashed code these days? :-). Where are the carriage returns that separate the parts? I'm just having trouble reading it mate :-).

[kbarber]

typo

[kbarber]

Can you add a rake file? :-) ... the one from puppetlabs-firewall is quite good and it gives me 'specs' (which is great for running rvm specs).

Besides the squashiness and the typo this is pretty good. Or at least as they say - 'better then having no tests' ;-).

[bodepd]

I updated the commit in response to your comments

[kbarber]

I haven't looked deeply into this I must admit, but I tried running:

rake spec

And:

rspec spec/unit/classes/ntp_spec.rb

And got:

1) ntp test platform specific resources for operating system debian 
 Failure/Error: it { should contain_service('ntp').with_name('ntp') }
 Puppet::Error:
   Could not find class ntp for kb.local at line 3 on node kb.local
 # ./spec/../../puppet/lib/puppet/indirector/catalog/compiler.rb:77:in `compile'
 # ./spec/../../puppet/lib/puppet/indirector/catalog/compiler.rb:75:in `compile'
 # ./spec/../../puppet/lib/puppet/indirector/catalog/compiler.rb:35:in `find'
 # ./spec/classes/ntp_spec.rb:23

Is this just a modulepath thing? Sorry I'm quite brain-dead today :-). I guess either way 'rake spec' should just work - at least that would be the expectation.

[bodepd]

Did you create the symlink from puppetlabs-ntp -> ntp ? It looks like a modulepath thing

[kbarber]

Yeah - symlink was it - thanks. Hmm. Maybe we should import these things or something to avoid the need :-). shrug.