(MODULES-10413) Allow custom ntp user and daemon options #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david22swan
force-pushed
the
devel-user
branch
4 times, most recently
from
1cf1749 to
8d48a10
Compare
david22swan
changed the title
sheenaajay
reviewed
Jan 10, 2020
manifests/config.pp
Outdated
| match => '^OPTIONS\=', | ||
| } | ||
| } | ||
| # if $ntp::user { |
There was a problem hiding this comment.
@david22swan should we keep the commented block or remove them
david22swan
force-pushed
the
devel-user
branch
from
8d48a10 to
e10f1cc
Compare
sheenaajay
approved these changes
Jan 10, 2020
sheenaajay
reviewed
Jan 10, 2020
REFERENCE.md
Outdated
| Data type: `Optional[String]` | ||
|
|
||
| Specifies any arguments to pass to ntp daemon. Default value: '-g'. | ||
| Example value: '-g -i /var/lib/ntp' to enaible jaildir options. |
sheenaajay
reviewed
Jan 10, 2020
REFERENCE.md
Outdated
|
|
||
| Specifies user to run ntpd daemon. Default value: ntp. | ||
| Usually set by default on Centos7 (/etc/systemd/system/multi-user.target.wants/ntpd.service) and ubuntu 18.04 (/usr/lib/ntp/ntp-systemd-wrapper) | ||
| This is currently restricted to Redhat based systems of version 7 and aboce and Ubuntu 18.04. |
sheenaajay
reviewed
Jan 10, 2020
manifests/init.pp
Outdated
| @@ -28,6 +28,11 @@ | |||
| # Specifies an absolute or relative file path to an ERB template for the config file. | |||
| # Example value: 'ntp/ntp.conf.erb'. A validation error is thrown if both this **and** the `config_epp` parameter are specified. | |||
| # | |||
| # @param daemon_extra_opts | |||
| # Specifies any arguments to pass to ntp daemon. Default value: '-g'. | |||
| # Example value: '-g -i /var/lib/ntp' to enaible jaildir options. | |||
sheenaajay
reviewed
Jan 10, 2020
manifests/init.pp
Outdated
| # @param user | ||
| # Specifies user to run ntpd daemon. Default value: ntp. | ||
| # Usually set by default on Centos7 (/etc/systemd/system/multi-user.target.wants/ntpd.service) and ubuntu 18.04 (/usr/lib/ntp/ntp-systemd-wrapper) | ||
| # This is currently restricted to Redhat based systems of version 7 and aboce and Ubuntu 18.04. |
david22swan
force-pushed
the
devel-user
branch
from
e10f1cc to
ff9869b
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #489