Loc+ strings edit #359
Merged
Loc+ strings edit #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I forgot I did a progress commit... I can squash these if you want. |
|
@jbondpdx If this is ready for review I'd say go ahead and squash that WIP commit! But if you have more work to do I'd wait and squash later |
|
Nah, @HAIL9000 , no more work on it... I don't PR until it's ready for review. And I've squashed the commits (someday I won't have to look that up every time!). |
|
@jbondpdx looks good to me, nice changes 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General edit of the ntp module readme, in prep for localization work and adding docs strings to code.
Of note, I've (mostly) pulled out "valid values" from descriptions, but added data types at the front of the descriptions. These types appeared to cover valid values for the most part, and having them at the front of the description will make strings import easier and let the user know up front what they are dealing with.