fairly trivial fix to make puppet-lint stop complaining, and a doc update #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puppet-lint was complaining about "ensure found on line but it's not the first attribute on line 109". Trivial fix (swapped the ensure and the name). Also, the README didn't mention Debian or CentOS, but the comment block in init.pp did. I added both to the README. I happen to be using this with Debian unstable, but I haven't tested it extensively enough to say "yep, this works". It, however, works for me.
jamtur01
added a commit
that referenced
this pull request
Nov 5, 2012
fairly trivial fix to make puppet-lint stop complaining, and a doc update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puppet-lint was complaining about "ensure found on line but it's not the
first attribute on line 109". Trivial fix (swapped the ensure and the
name).
Also, the README didn't mention Debian or CentOS, but the comment block
in init.pp did. I added both to the README. I happen to be using this
with Debian unstable, but I haven't tested it extensively enough to say
"yep, this works". It, however, works for me.