Add parameter for interfaces to ignore #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ntp configuration supports some tokens for interfaces that shall be ignored. Previously the module used the pattern 'wildcard' to indicate that ntp shouldn't listen to any interface but those specified as listen interfaces. In some circumstances this is not enough. This commit adds a new parameter interfaces_ignore that allows to list all interfaces (or interface tokens like all, ipv6, ipv6 etc.) that should be ignored.
|
Hi There Can you specify a use case where a property like this would be needed? Thanks |
|
If for nothing else: To be able to reproduce a working, tested and reviewed configuration with puppet (and a supported module :-) More serious: We support a setup where IPv6 must be disabled due to regulatory parameters. I don't exactly recall the exact reason, but for this setup to work we needed to explicitly configure "interface ignore ipv6" additionally to "interface ignore wildcard". |
|
Hey @aptituz , this is a great addition, thank you! Merging now :) |
HelenCampbell
pushed a commit
that referenced
this pull request
Feb 16, 2016
Add parameter for interfaces to ignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ntp configuration supports some tokens for interfaces that shall be ignored.
Previously the module used the pattern 'wildcard' to indicate that ntp
shouldn't listen to any interface but those specified as listen interfaces.
In some circumstances this is not enough. This commit adds a new parameter
interfaces_ignore that allows to list all interfaces (or interface tokens
like all, ipv6, ipv6 etc.) that should be ignored (and overrides the wildcard token).