-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MODULES-2210 Add TOS Parameter #282
Conversation
petems
commented
Jul 13, 2015
$tos_minsane = 1 | ||
$tos_floor = 1 | ||
$tos_ceiling = 15 | ||
$tos_cohort = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the parameters other than $tos
be exposed in class ntp
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, adding those in now! 👍
@petems so, one question above, but otherwise this needs documentation updates for the new parameter. Thanks! |
@mhaskel Done! 👍 |
####`tos_cohort` | ||
|
||
Specifies the cohort tos option. Valid options: '0' or '1'. Default value: varies by operating system | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all of these Default value: varies by operating system
, it looks like params actually has a consistent default for all oses, so that should probably be listed instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, will fix 👍
Hey @petems , Looks like tests are failing now, and new tests should be added to cover the additional params I got you to add :) Otherwise, just the doc updates, and if you could squash this down a little bit that would be awesome! Thanks! |
Hi @petems , this change looks good, but would clutter the git history in its current state. Please squash them together and re-push here. |
@tphoney Done! 👍 |
MODULES-2210 Add TOS Parameter
Great work @petems |
👍 |