Fix is_virtual check in ntp.conf templates #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is_virtual fact must be checked using a string comparison. The previous logic would resolve true if the is_virtual fact was defined. This meant that on servers where is_virtual was defined as "false", the vm-only snippet was still inserted into the template.
branan
pushed a commit
that referenced
this pull request
Oct 19, 2012
Fix is_virtual check in ntp.conf templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_virtual fact must be checked using a string comparison.
The previous logic would resolve true if the is_virtual fact was
defined. This meant that on servers where is_virtual was defined as
"false", the vm-only snippet was still inserted into the template.