Update tests to ignore warnings but still look for errors

spec/acceptance/class_spec.rb

@@ -6,10 +6,11 @@
 
     # Apply twice to ensure no errors the second time.
     apply_manifest(pp, :catch_failures => true) do |r|
-      expect(r.stderr).to eq("")
+      expect(r.stderr).not_to match(/error/i)
     end
     apply_manifest(pp, :catch_failures => true) do |r|
-      expect(r.stderr).to eq("")
+      expect(r.stderr).not_to eq(/error/i)
+
       expect(r.exit_code).to be_zero
     end
   end
@@ -19,7 +20,7 @@
       pp = "class { 'ntp': service_ensure => stopped }"
 
       apply_manifest(pp, :catch_failures => true) do |r|
-        expect(r.stderr).to eq("")
+        expect(r.stderr).not_to match(/error/i)
       end
     end
   end
@@ -29,7 +30,7 @@
       pp = "class { 'ntp': service_ensure => running }"
 
       apply_manifest(pp, :catch_failures => true) do |r|
-        expect(r.stderr).to eq("")
+        expect(r.stderr).not_to match(/error/i)
       end
     end
   end

spec/acceptance/ntp_parameters_spec.rb

@@ -23,7 +23,7 @@
     pp = "class { 'ntp': }"
 
     apply_manifest(pp, :catch_failures => true) do |r|
-      expect(r.stderr).to eq("")
+      expect(r.stderr).not_to match(/error/i)
     end
   end
 

spec/acceptance/preferred_servers_spec.rb

@@ -10,7 +10,7 @@ class { '::ntp':
 
   it 'applies cleanly' do
     apply_manifest(pp, :catch_failures => true) do |r|
-      expect(r.stderr).to eq("")
+      expect(r.stderr).not_to match(/error/i)
     end
   end
 

spec/acceptance/restrict_spec.rb

@@ -7,7 +7,8 @@
     it 'runs twice' do
       2.times do
         apply_manifest(pp, :catch_failures => true) do |r|
-          expect(r.stderr).to be_empty
+          expect(r.stderr).not_to match(/error/i)
+          expect(r.exit_code).to be_zero
         end
       end
     end