Fix group on FreeBSD #1226
Merged
Fix group on FreeBSD #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jas01 Thanks for submitting the PR. Could you please rebase with the master.Changes in master for the acceptance tests to run clean. |
|
Le 06/09/2019 à 03:26:26-0700, sheenaajay a écrit
@jas01 Thanks for submitting the PR. Could you please rebase with the
master.Changes in master for the acceptance tests to run clean.
Just did the rebase
Regards
|
|
@jas01 looks like it has pulled all commits from the master.I think we can open a new PR with the changes. |
The server::backup class don't use the correct information from mysql::params about backupdirgroup. Because on FreeBSD the group root doesn't exist it should use wheel instead. This difference are correctly configure inside mysql::params but not inside server::backup
jas01
force-pushed
the
fix-group-freebsd
branch
from
595c448 to
0cdf8d6
Compare
|
Le 11/09/2019 à 05:56:00-0700, sheenaajay a écrit
@jas01 looks like it has pulled all commits from the master.I think we can open
a new PR with the changes.
I just did a clean rebase, and force push on my repot, the travis just
restart again. We will see if it's ok.
Regards
|
|
@jas01 That's perfect.Let me rerun the job |
|
Great work @jas01 merged !!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server::backup class don't use the correct information from
mysql::params about backupdirgroup. Because on FreeBSD the group root
doesn't exist it should use wheel instead. This difference are
correctly configure inside mysql::params but not inside server::backup