Enable module to not use default options #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morremeyer
force-pushed
the
feature/disable_default_conf
branch
3 times, most recently
from
f9de949 to
13ed0e9
Compare
morremeyer
force-pushed
the
feature/disable_default_conf
branch
from
13ed0e9 to
7ac8328
Compare
bastelfreak
reviewed
Jun 12, 2019
|
Thanks @mauricemeyer for submitting the PR. Could you please incorporate comments. Thank you @bastelfreak for the valuable comments. |
morremeyer
force-pushed
the
feature/disable_default_conf
branch
from
7ac8328 to
8c88a27
Compare
|
@sheenaajay Thanks for the reminder! I updated the PR, let’s see what @bastelfreak thinks :) |
|
Thank you @mauricemeyer . |
morremeyer
force-pushed
the
feature/disable_default_conf
branch
2 times, most recently
from
4d3f420 to
d236908
Compare
|
The test for Puppet 5 failed, but it looks to me like a test problem? I can’t restart the test, though. |
|
@mauricemeyer magic travis trick: close + reopen the PR will retrigger travis. |
|
@bastelfreak Works like a charm, thanks. |
|
close and reopen to rerun tests |
|
Hello @mauricemeyer , It looks good to me! Thank you! Cheers!
|
lionce
approved these changes
Nov 7, 2019
kubicgruenfeld
force-pushed
the
feature/disable_default_conf
branch
from
d236908 to
1864190
Compare
sheenaajay
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables you to either use:
override_optionsas it was the case previously. Those options are merged with the default optionsoptions. Those options won’t be merged with the default options.Both are mutually exclusive in usage, meaning that one of them has to be empty.
I wrote this PR because we want to get rid of the version specific configuration options as it makes our workflows for changes of default parameters in our profiles easier.
I wrote it like this so that it has clean semantics:
Therefore, this PR is fully backwards compatible.