[MODULES-8779] Set proper python_package_name for RHEL/CentOS 8 #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdoproject
pushed a commit
to rdo-packages/puppet-mysql-distgit
that referenced
this pull request
Feb 21, 2019
There is an open pull request to puppet-mysql [1] to add support for RHEL 8 packages, where MySQL-python is not available. While it is discussed, let's add it to RDO to allow progress. [1] - puppetlabs/puppetlabs-mysql#1161 Change-Id: I5d1c4fd7812b8a3222e8ab1a96c8f220f40fda33
|
Hi @javierpena . Thanks for your PR! We do not currently support RedHat 8 however I have tested this change out and it appears to work as intended. Would you be able to add a ticket to your commit message? See here for more info. Cheers! |
mysql::bindings::python installs the package set by the python_package_name variable, which is 'MySQL-python' by default on all RHEL and Fedora-based systems. This is no longer valid for RHEL 8, since there is no Python3 support for the package. In RHEL 8, we should use python-PyMySQL instead.
javierpena
changed the title
|
Thanks for the tip @eimlav. I have opened the ticket and changed the commit message to include it. |
|
@javierpena Looks good thanks for adding these changes! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mysql::bindings::python installs the package set by the
python_package_name variable, which is 'MySQL-python' by default
on all RHEL and Fedora-based systems. This is no longer valid for
RHEL 8, since there is no Python3 support for the package.
In RHEL 8, we should use python3-PyMySQL instead.