Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing query_cache ops that are no longer supported in MySQL >= 8.0 #1107

Merged

Conversation

ernstae
Copy link
Contributor

@ernstae ernstae commented Aug 3, 2018

While using MySQL 8.0, the configuration options in the mysqld params section had query_cache_limit and query_cache_size variables which are no longer supported for MySQL >= 8.0

Moving these into the version-specific hashes, rather than the mysqld default hash. I didn't love having to duplicate those entries, but it does follow the same pattern of the myisam-recover option. 🤷‍♂️

This results in MySQL 8.0.12 actually starting up, rather than throwing the following error example:

[ERROR] [MY-011071] [Server] unknown variable 'query_cache_limit=1M'

@ernstae
Copy link
Contributor Author

ernstae commented Aug 4, 2018

Users who are looking to override this variable can always undef it in hiera:

mysql::server::override_options:
  mysqld:
    query_cache_limit: ~
    query_cache_size: ~

@david22swan david22swan merged commit 4ae123e into puppetlabs:master Nov 6, 2018
@lroehrs
Copy link

lroehrs commented Aug 11, 2021

To override query_cache_size and query_cache_limit, you have to set the specific version:

mysql::server::override_options:
  mysqld-5.7:
    query_cache_size: ~

The options in mysqld will be overrided from the default values:

https://github.com/puppetlabs/puppetlabs-mysql/blob/main/manifests/params.pp#L491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants