FM-8219 - Convert to litmus #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionce
force-pushed
the
convert_to_litmus
branch
9 times, most recently
from
12ae32a to
9867560
Compare
tphoney
suggested changes
Sep 18, 2019
| shell("sed -i -e \'s/^templatedir.*$//\' #{config}") | ||
| config = run_shell('puppet config print config').stdout | ||
| run_shell("sed -i -e \'s/^templatedir.*$//\' #{config}") | ||
| run_shell('echo export LC_ALL=C > ~/.bashrc') |
There was a problem hiding this comment.
should this live somewhere else ? other modules likely need this
There was a problem hiding this comment.
this was needed for el platforms provisioned with docker
lionce
force-pushed
the
convert_to_litmus
branch
9 times, most recently
from
b0934d8 to
6422370
Compare
lionce
force-pushed
the
convert_to_litmus
branch
2 times, most recently
from
1d8cc70 to
3769eab
Compare
…ioned with docker
lionce
force-pushed
the
convert_to_litmus
branch
from
a3823c7 to
eb46238
Compare
tphoney
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tickets.puppetlabs.com/browse/FM-8219
we encountered some issues during our convertion to litmus
using provisioner docker_exp -> some setups were missing.
(iptables is not installed. root profile should be updated. missing folder /lib/modules/
uname -r)1. applying manifest containing inverted rule is returning error
pp.pp
class
{ '::firewall': }
firewall
{ '603 drop 80,443 traffic': chain => 'INPUT', action => 'drop', proto => 'tcp', sport => ['! http', '443'], }
Error: Parameter sport failed on Firewall[603 drop 80,443 traffic]: Munging failed for value "! http" in class sport: no such service http/tcp
2. testing ct_target_zone disconnected the machine
spec/acceptance/firewall_attributes_ipv6_happy_path_spec.rb
spec/acceptance/firewall_attributes_happy_path_spec.rb
describe 'test CT target attributes which are not available on some OS', unless:
3. connlimit not available on some operating systems
removed them from the manifest.