Treat RHEL 7 and later like Fedora w/r/t iptables #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RHEL 7 replaces legacy init with systemd, and must be treated like Fedora w/r/t iptables persistence. This patches checks operatingsystemrelease in addition to operatingsystem in order to differentiate between RHEL 7 and earlier releases. Both RHEL 7 and recent Fedora releases require the iptables-services package to support the commands in lib/puppet/util/firewall.rb. This also corrects the path to /usr/libexec/iptables/iptables.init.
I like explicitly quoted strings, but apparently Travis doesn't.
|
Okay, now Travis CI is just being silly. Those failures are due to rake version requirements and are probably failing for everybody. |
openstack-gerrit
pushed a commit
to redhat-openstack/packstack
that referenced
this pull request
Mar 27, 2014
Puppet automatically loads custom resources types provided by modules, but does not automatically run the manifests provided by the module. Module manifests are only activated by explicitly "including" the module. The "firewall" module manifests take care of ensuring that the necessary packages are installed to support the commands used in the firewall resource type. This patch includes the firewall module in the prescript.pp template, which ensures that the appropriate packages are loaded before firewall resources are realized. This patch is related to the following upstream pull request for the firewall module, which ensures that the proper packages are installed on Fedora and RHEL 7: puppetlabs/puppetlabs-firewall#338 Change-Id: I13ba5ae20b3c9d4a605b1358bd343aa730c63eaf Closes-bug: 1297857
apenney
pushed a commit
that referenced
this pull request
Apr 3, 2014
Treat RHEL 7 and later like Fedora w/r/t iptables
cegeka-jenkins
pushed a commit
to cegeka/puppet-firewall
that referenced
this pull request
Oct 23, 2017
Treat RHEL 7 and later like Fedora w/r/t iptables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RHEL 7 replaces legacy init with systemd, and must be treated like
Fedora w/r/t iptables persistence. This patches checks
operatingsystemrelease in addition to operatingsystem in order
to differentiate between RHEL 7 and earlier releases.
Both RHEL 7 and recent Fedora releases require the iptables-services
package to support the commands in lib/puppet/util/firewall.rb.
This also corrects the path to /usr/libexec/iptables/iptables.init.