(MODULES-442) Correct boolean properties behavior #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else | ||
| define_method "#{property}=" do |value| | ||
| @property_hash[:needs_change] = true | ||
| end |
There was a problem hiding this comment.
This is actually just backporting #288 to the ip6tables provider, but isn't part of the boolean fix.
The boolean properties had a few things incorrect with them. - Any value passed was considered `true`. This was compounded further by the next issue. - When the read property was false, it was set to 'nil'. This caused `<property> => false` to not work after the previous was fixed. Random other fixes to tests that were failing or poorly implemented are also included
apenney
pushed a commit
that referenced
this pull request
Feb 3, 2014
(MODULES-442) Correct boolean properties behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The boolean properties had a few things incorrect with them.
true. This was compounded further by the next issue.<property> => falseto not work after the previous was fixed.