fix handling of builtin chains #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Argh, looks like the specs are on fire after the recent rspec-puppet changes. I'll have to take a look and see if I can beat it into behaving before I merge anything. :D |
This was referenced Dec 19, 2013
apenney
pushed a commit
that referenced
this pull request
Dec 20, 2013
fix handling of builtin chains
cegeka-jenkins
pushed a commit
to cegeka/puppet-firewall
that referenced
this pull request
Oct 23, 2017
fix handling of builtin chains
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MOAR PULL REQUESTS!!!
There were several issues with regards to the handling of builtin chains.
First there were a couple places where a check was being performed to determine whether the provider was trying to create/delete a built-in chain. This check was broken and would never match.
Then there was an issue where if the
iptable_natmodule wasn't loaded, the nat chains wouldn't exist, and so the provider would try to create them. I added an exemption for the built-in chains so that the provider thinks they're always there, even if the module hasn't been loaded. We leave it up to the kernel to automatically load the module if/when we try and use that table.In theory this negates the need for the built-in chain check on
def create, but I left it in anyway.