debian: service: fix ensure parameter usage

[damonbreeden]

ensure is defined but not used anywhere, no clear way to ensure the service is running (and makes it impossible to do so outside the module)

[CLAassistant]

All committers have signed the CLA.

[puppet-community-rangefinder]

firewall::linux::debian is a class

that may have no external impact to Forge modules.

This module is declared in 106 of 580 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[jordanbreen28]

Hi @damonbreeden
Thanks for your work on this one, however it looks as though your change has introduced some spec test failures.
Are you able to address these failures?
Thanks

[kjetilho]

A rebase on "main" will probably fix the checks (and trigger a new run of checks)

[damonbreeden]

hi, your test failure expects the service to be unmanaged but IMO this is an oversight, since debian is the only distro that expects this (all others are set to respect the ensure param correctly) and since we define ensure => running in the class params but it's never used anywhere in the class

this makes it impossible to actually manage the running state of the service with puppet, since we define it here as undef so we can't define it anywhere else

[jordanbreen28]

hi @damonbreeden, thanks for providing some more context surrounding the test failures.

Please feel free to update the debian specific spec tests so that the now pass with this change. (When you have the free time!)

I suspect the failing RHEL-9 issues are due to your branch being outdated, and a fix has since been merged into main for this.

Thanks for your work on this one.

[damonbreeden]

hi @jordanbreen28 pls see latest commits, i think they address the spec tests correctly

[damonbreeden]

sorry, spoke too quickly
seems like it's failing on an unknown variable now, but (should be) unrelated to this PR

       Evaluation Error: Unknown variable: '::osfamily'. (file: /home/runner/work/puppetlabs-firewall/puppetlabs-firewall/spec/fixtures/modules/firewall/manifests/params.pp, line: 7, column: 8) on node fv-az191-465.ggaq42fduhvefhuza3ifwajfkf.bx.internal.cloudapp.net

edit: figured out where osfamily was missing, added it

[LukasAud]

LGTM