Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persistence: may fail on fresh Debian nodes #134

Closed
dcarley opened this issue Mar 1, 2013 · 2 comments
Closed

Persistence: may fail on fresh Debian nodes #134

dcarley opened this issue Mar 1, 2013 · 2 comments

Comments

@dcarley
Copy link
Contributor

dcarley commented Mar 1, 2013

Improvements on #133

Persistence may fail on fresh Debian/Ubuntu nodes if Package['iptables-persistent'] isn't installed before the first Firewall[] resource is created.

Possible solutions:

  1. Have the type auto-require the package if it exists in the catalog. Is this bad form?
  2. Write a flag file to indicate that persistence should be attempted on the next run even if no rules have changed.
@kbarber
Copy link
Contributor

kbarber commented Mar 1, 2013

Autorequire. It will silently fail if the class isn't there anyway. Just return a message about installing the firewall class or something if you think that is the reason for failing ... probably need a small mention of the firewall class in docs.

dcarley added a commit to dcarley/puppetlabs-firewall that referenced this issue Mar 1, 2013
@dcarley
(puppetlabsGH-134) Autorequire iptables related packages
a28c3ae 
autorequires from firewall and firewallchain resources to iptables and
iptables-persistent packages, when the appropriate provider is selected and
the packages are managed in the catalog. This will prevent failed rule
creation and persistence on fresh nodes where the packages may not be
pre-installed.
dcarley added a commit that referenced this issue Mar 1, 2013
@dcarley
(GH-134) Refer to new classes in documentation.
640a298
kbarber added a commit that referenced this issue Mar 1, 2013
@kbarber
Merge pull request #136 from dcarley/134-autorequire_packages
117a8bc 
(GH-134) Autorequire iptables related packages
@dcarley
Copy link
Contributor Author

dcarley commented Mar 1, 2013

Fixed in #136

@dcarley dcarley closed this as completed Mar 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kbarber @dcarley