(MODULES-5654) Support for proxies during installation #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @GeoffWilliams, we were able to do some manual validation of this change today, and things look good. Could you please re-base this branch onto the current position of master so that we can get this merged? |
GeoffWilliams
force-pushed
the
install_proxy
branch
2 times, most recently
from
a716ad7 to
a5a57f8
Compare
|
rebased onto master, all yours |
|
Hi @GeoffWilliams , unfortunately, we are going to need another rebase to get this PR in. Travis had an issue the required us to make the changes you see in #129 . Without a rebase to incorporate those changes into your PR, we won't be able to merge because Travis checks can't pass. |
RandomNoun7
force-pushed
the
install_proxy
branch
from
a5a57f8 to
a264763
Compare
Add a new parameter `install_proxy` to specify a proxy server to use during installation in the form `http://proxy.megacorp.com:3128`. This will be conditionally munged into the `InstallChocolatey.ps1.erb` script and used to configure the `System.Net.WebRequest` instance which is used to download all required assets
RandomNoun7
force-pushed
the
install_proxy
branch
from
a264763 to
17f82fc
Compare
ThoughtCrhyme
approved these changes
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new parameter
install_proxyto specify a proxy server to use during installation in the formhttp://proxy.megacorp.com:3128. This will be conditionally munged into theInstallChocolatey.ps1.erbscript and used to configure theSystem.Net.WebRequestinstance which is used to download all required assets