(Modules-4508) Fixed error with version parameter

[derek-robinson]

Using one dash instead of two for a parameter causes chocolatey to think
the parameter is a bundled option (like -dvyf means --debug --verbose
--confirm --force).

[ferventcoder]

@Koshersalt there are a few more places this will need to be fixed.

Also, I started a branch to see if Chocolatey was 0.9.9+ and automatically use -- in places like that.

[ferventcoder]

Started being the keyword there...

[derek-robinson]

Yeaaaah, I realized after the tests came back that it wasn't quite the quick fix I'd hoped lol.
So I'm assuming your 9.9+ branch would be the preferred route. If so should I go ahead and close this PR?

[ferventcoder]

@Koshersalt hold tight. I have to still find that branch ;)

[glennsarti]

@ferventcoder To summarise then...behaviour of --version and -versions is different between Choco 0.9.9 and above 0.9.9?

[jpogran]

Updated PR with modified spec tests, so now all specs pass. Will try to sync up with @ferventcoder to see if I can help identify the other areas he speaks of to change

[glennsarti]

Seems related to chocolatey-archive#149

[glennsarti]

@ferventcoder Looks like chocolatey/choco@51d59c8 has regressed

[glennsarti]

Confirmed that this was not an issue using Choco 0.9.9.12 but then started failing 0.9.10. This fix uses --version which is compatible with older Choco versions so changing it to double dash across the board is fine.

[glennsarti]

Running through Adhoc CI to make sure it's all ok

[glennsarti]

Adhoc is green. Merging

[ferventcoder]

It's the diff btw 0.9.8.x and below and 0.9.9+

[ferventcoder]

Which the supported module probably will no longer support. It may be a good idea to double dash all long names.