(MODULES-4210) Do not use com unzip in PS 5+ #56
Conversation
At least in Windows 10, the use of COM objects for unizp does not seem to work in a non-interactive session
helge000
force-pushed
the
MODULES-4210
branch
from
9ac36c9 to
a3da9b3
Compare
helge000
changed the title
|
I tested this patch in our env using Windows 8.1 and Windows 10 clients |
| $destinationFolder = $shellApplication.NameSpace($tempDir) | ||
| $destinationFolder.CopyHere($zipPackage.Items(),0x10) | ||
| if ($PSVersionTable.PSversion.major -lt 5) { | ||
| $shellApplication = new-object -com shell.application |
There was a problem hiding this comment.
We should also change this part while we at it:
Add-Type -AssemblyName System.IO.Compression.FileSystem
[System.IO.Compression.ZipFile]::ExtractToDirectory($file, $tempDir)
I use this in many Puppet / Powershell scripts in lack of Expand-Archive
There was a problem hiding this comment.
This is likely only in .NET Framework 4.x forward, but if you are in PowerShell v4+ you are guaranteed to be on at least v4. With 5 you have a guarantee of at least 4.5.
There was a problem hiding this comment.
I actually never tested the assembly part on PS < 4, but it was a new feature in .NET2.0:
https://msdn.microsoft.com/en-us/library/system.io.compression(v=vs.80).aspx
The Expand-Archive - commandlet is a new (and long anticipated) feature of PS 5.
There was a problem hiding this comment.
No dice - needs at least 4.5 for ZipFile - https://msdn.microsoft.com/en-us/library/system.io.compression.zipfile(v=vs.110).aspx
|
No problem! By the way, the chocolatey/chocolaty has the same issue. |
|
I manage the sync up between the two, so no need to open anything over on the community module. |
(QA-2848) QAELK - No skip results
At least in Windows 10, the use of COM objects for unizp does not seem
to work in a non-interactive session