Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-4149) Unsuitable providers should not error #54

Conversation

ferventcoder
Copy link

When attempting to force the provider, validation would error due
to the version coming back would not be above the version that is
being validated. When the provider is unsuitable, it should not
return an error during the Puppet run and should instead just
return the unsuitable message.

Check to ensure Chocolatey is installed prior to allowing the
validation check to not fail the Puppet run.

@ferventcoder ferventcoder force-pushed the ticket/master/MODULES-4149-allow_suitability branch from 556d2b3 to 581e90a Compare December 6, 2016 22:10
@ferventcoder
Copy link
Author

image

@ferventcoder
Copy link
Author

class {'chocolatey':
  chocolatey_download_url => 'file:///C:/vagrant/resources/packages/chocolatey.0.10.3.nupkg',
  use_7zip                => false,
  log_output              => true,
  choco_install_location  => 'c:\choco',
}

chocolateyfeature {'allowEmptyChecksums':
  ensure => enabled,
  provider => 'windows',
}

chocolateyconfig {'cacheLocation':
  value => 'c:\ProgramData\choco-cache',
  provider => 'windows',
}

chocolateysource{ 'nexus':
  ensure   => present,
  location => 'http://localhost',
  provider => 'windows',
}

@ferventcoder
Copy link
Author

Second convergence works appropriately.

@ferventcoder ferventcoder force-pushed the ticket/master/MODULES-4149-allow_suitability branch 2 times, most recently from a464694 to 2d69248 Compare December 7, 2016 20:19
When attempting to force the provider, validation would error due
to the version coming back would not be above the version that is
being validated. When the provider is unsuitable, it should not
return an error during the Puppet run and should instead just
return the unsuitable message.

Check to ensure Chocolatey is installed prior to allowing the
validation check to not fail the Puppet run.
@ferventcoder ferventcoder force-pushed the ticket/master/MODULES-4149-allow_suitability branch from 2d69248 to 66508a3 Compare December 8, 2016 00:01
@eputnam eputnam merged commit 518e5b1 into puppetlabs:master Dec 12, 2016
@ferventcoder ferventcoder deleted the ticket/master/MODULES-4149-allow_suitability branch December 14, 2016 15:55
ThoughtCrhyme pushed a commit to ThoughtCrhyme/puppetlabs-chocolatey that referenced this pull request Mar 20, 2017
Updates reference to vmfloaty in the qamodule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants