(MODULES-3391) Limit rake spec on older puppet
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # If puppet does not support symlinks (e.g., puppet <= 3.5) we cannot use | ||
| # puppetlabs_spec_helper's `rake spec` task because it requires symlink | ||
| # support. Redine `rake spec` without the symlink call and restrict the pattern |
There was a problem hiding this comment.
Thanks! Had a commit staged and forgot to push. Will fixup once we've resolved all comments.
MosesMendoza
force-pushed
the
MODULES-3391/master/restrict_tests_on_older_puppet
branch
2 times, most recently
from
7860a8d to
4dab278
Compare
The default `rake spec` task provided by puppetlabs_spec_helper requires symlink support in puppet to put fixtures in place for testing. Older versions of Puppet do not support symlinks on Windows. This commit adds a check in the Rakefile for whether or not Puppet supports symlinks, and if it does not, redefines the `rake spec` task that has been defined by puppetlabs_spec_helper, to accomplish two objectives: - Remove the call to `rake spec_prep` which prepares all fixtures and requires symlinks - Restrict the pattern for matching tests to those under the 'unit' and 'integration' directories (other tests require the fixture we won't have) This feels a bit like overreaching into puppetlabs_spec_helper, but the alternative seems to be to duplicate the `rake spec` task in its entirety here or make even greater assumptions in puppetlabs_spec_helper about the constitution of modules other than puppetlabs-chocolatey. Signed-off-by: Moses Mendoza <[email protected]>
ThoughtCrhyme
pushed a commit
to ThoughtCrhyme/puppetlabs-chocolatey
that referenced
this pull request
Mar 20, 2017
* updated install script to create custom fact * updated site to use new qa modules * adding new qa modules * update to source xcode file correctly * updated $path for running xcode script * added gemset and bundler * adding floaty gem * adding software module * update to use seamymckenna fork of bitbar * update to use root to config def rvm gemset * update to not use root to config def rvm gemset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default
rake spectask provided by puppetlabs_spec_helper requires symlink support in puppet to put fixtures in place for testing. Older versions of Puppet do not support symlinks on Windows. This PR adds a check in the Rakefile for whether or not Puppet supports symlinks, and if it does not, redefines therake spectask that has been defined by puppetlabs_spec_helper, to accomplish two objectives:rake spec_prepwhich prepares all fixtures and requiressymlinks
(other tests require the fixture we won't have)
This feels a bit like overreaching into puppetlabs_spec_helper, but the alternative seems to be to duplicate the
rake spectask in its entirety here or make even greater assumptions in puppetlabs_spec_helper about the constitution of modules other than puppetlabs-chocolatey.Signed-off-by: Moses Mendoza [email protected]