(Modules 3391) remove rake test and fix failing test
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bundle exec rake test command in the chocolatey Rakefile runs an incomplete set of tests with a missing dependency on bundle exec rake spec_prep. After further investigation, it turns out puppetlabs_spec_helper defines rake spec which runs all the spec tests and does appropriate prep setup/teardown. After discussing with @glennsarti and @ThoughtCrhyme it seems like the correct call here is to run bundle exec rake spec instead of extending bundle exec rake test to further duplicate it. This commit specifically just removes the `rake test` task from Rakefile to avoid further confusion. It is believed that since the module is pre-1.0 this change, which might be considered backwards-incompatible is acceptable. Signed-off-by: Moses Mendoza <[email protected]>
Prior to this commit a test in the config_spec was failing with:
Mocha::ExpectationError:
unexpected invocation: #<AnyInstance:Win32::Registry>.[]('Domain')
satisfied expectations:
- allowed any number of times, invoked 4 times:
#<AnyInstance:Win32::Registry>.[]('ChocolateyInstall')
- allowed any number of times, not yet invoked:
#<Puppet::Util::Feature:0x45b5be0>.root?(any_parameters)
This is because a facter fact was making a call to Win32::Registry.[] which
hadn't been stubbed (two, in fact). This commit adds these stubs to the
spec_helper in addition to the existing one. This commit makes test pass, but
may be more brittle than a more generic stub that doesn't specify the
parameter. This commit assumes the specificity is of higher value.
Signed-off-by: Moses Mendoza <[email protected]>
|
Note: this depends on https://github.com/puppetlabs/ci-job-configs/pull/1530. That PR should be merged first to avoid CI breakage |
MosesMendoza
changed the title
rake test and fix failing test
MosesMendoza
changed the title
rake test and fix failing testrake test and fix failing test
|
👍 merge when CI config is merged. |
|
Supersedes #32 |
ThoughtCrhyme
pushed a commit
to ThoughtCrhyme/puppetlabs-chocolatey
that referenced
this pull request
Mar 20, 2017
Adding initial version of vmfloaty module for laptop puppetisation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bundle exec rake test command in the chocolatey Rakefile runs an incomplete set of tests with a missing dependency on
bundle exec rake spec_prep. After further investigation, it turns outpuppetlabs_spec_helperdefinesrake specwhich runs all the spec tests and does appropriate prep setup/teardown. After discussing with @glennsarti and @ThoughtCrhyme it seems like the correct call here is to runbundle exec rake specinstead of extendingbundle exec rake testto further duplicate it.This PR specifically just removes the
rake testtask from Rakefile to avoid further confusion. It is believed that since the module is pre-1.0 this change, which might be considered backwards-incompatible is acceptable. I'm happy to work up something more backwards-compatible via task redirection if we think that's appropriate.This PR also resolves a failing test:
This is because facter fact(s) were making a call to
Win32::Registry.[]which hadn't been stubbed (two, in fact). This commit adds these stubs to the spec_helper in addition to the existing one. This makes test pass, but may be more brittle than a more generic stub that doesn't specify the parameter. I assume we prefer higher specificity, but I'm happy to revise to a single line with justWin32::Registry.any_instance.stubs(:[])if preferred.Signed-off-by: Moses Mendoza [email protected]