(MODULES-3275) Chocolatey module testing #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| step "Uninstall #{package_name} package via manifest" | ||
| apply_manifest(chocolatey_package_manifest, :catch_failures => true) do |result| | ||
| #validate | ||
| assert_match(/Stage\[main\]\/Main\/Package\[#{package_name}\]\/ensure\: removed/, result.stdout, "stdout did not report package removal of #{package_name}") |
There was a problem hiding this comment.
Since this is a known failure, shouldn't this be set to the known failure for now?
|
Can you fix up your git commit summary to be 50 chars or less and then include a commit message body? |
ThoughtCrhyme
force-pushed
the
MODULES-3275
branch
3 times, most recently
from
dd13223 to
2cd2ba1
Compare
|
Can you rebase against master on this? Your specs are failing by something fixed in latest master. |
ThoughtCrhyme
changed the title
|
Rebase, never merge. 👍 |
ThoughtCrhyme
force-pushed
the
MODULES-3275
branch
from
53d303b to
42df9af
Compare
ThoughtCrhyme
force-pushed
the
MODULES-3275
branch
from
42df9af to
ffc906d
Compare
Tests for installing and removing packages with and without UTF-8
ThoughtCrhyme
pushed a commit
to ThoughtCrhyme/puppetlabs-chocolatey
that referenced
this pull request
Mar 20, 2017
…7/update_format_for_maint (QA-2667) Update "parse_status" to Track Maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for installing and removing packages with and without UTF-8 characters.
Currently failing to apply the manifest correctly for package with UTF-8 characters, see install_and_remove_good_package_utf-8.rb line 60.