(MODULES-8521) Fix $chocolatey_version parameter

[helge000]

Fixes $chocolatey_version to acually bootstrap the given version of
chocolatey.

[ferventcoder]

The Chocolatey version parameter is documented to be informational only. I regret having added it for the confusion that it brings when people see it.

[ferventcoder]

The documentation states that the download url should download a nupkg if you go to it on a bare url. So this change would not be enough.

[ferventcoder]

Moreover it would be an incorrect change (to clarify).

[helge000]

The Chocolatey version parameter is documented to be informational only

Are you interested in making it work or do you prefer it the way it is? In this case, pls close the PR but maybe leave the bug open.

No harm done :)

[helge000]

@ferventcoder - Right, this should work now: Download URI renders to https://chocolatey.org/api/v2/package/chocolatey/0.10.10

[helge000]

A catch would be if the last / is missing from @download_url. Should I add another regex? In this case, it would look nicer in it's own code block.

[ferventcoder]

The problem is you are only showing how to make it work with the community repo. What about Artifactory, Nexus, ProGet, Chocolatey Simple Server, a file location, or any other the other repository types?

90% of the time the expectation is that an organization is using Puppet and Chocolatey, which means not using the community package repository, even to install Chocolatey. See https://chocolatey.org/docs/how-to-setup-offline-installation for our guide on organizational use.

[helge000]

I think all these use cases are fairly easy to cover; we only need to check if our download URL matches something like /^http(s):\/\/.*api/v2/package.*\/$/. IMHO the version param is only applicable when using a nuget server for downloads anyway.

which means not using the community package repository

This is also our use case; however we do sync the choco package from community to or internal nuget and therefore I most likely end up installing the most recent version instead the version I specify in my manifest.

[helge000]

@ferventcoder, you think this covers it?

[lionce]

Hello @helge000 ,

In order to merge this PR, please resolve the conflicts and rebase it with the latest code version.

Thanks!

[AmarettoSlim]

@ferventcoder - How do you envision people ensuring they have the version of chocolatey they want installed with chocolatey_version being information only?

I've decided to do the following:

1. Host the chocolatey package I want installed in an instance of artifactory, set a variable to the package and pass it to chocolatey_download_url

2. Configure chocolatey sources as I desire (adding artifactory)

3. Have a package defined for managing chocolatey itself, pointing it to the desired version I want.

On first run will result in chocolatey installing whatever version the module uses, and then upgrade itself, subsequent runs do nothing regarding the class instantiation but chocolatey can be upgraded using the package resource.

I suspect this is the way to go for now unless you have plans for chocolatey_version to be more than informational?

Thanks for your time, I appreciate it, and of course, thanks for Chocolatey!

class profile::chocolatey {

  $chocolatey_download_url = "https://artifactory.domain.com/nuget-local/chocolatey.${lookup('chocolatey_version')}.nupkg"
  class { 'chocolatey':
    chocolatey_download_url => $chocolatey_download_url
  }

  chocolateysource { 'chocolatey':
    ensure => disabled
  }

  chocolateysource { 'Artifactory':
    ensure   => present,
    location => lookup('artifactory_nuget_url'),
    priority => 1
  }

  package { 'chocolatey':
    ensure   => lookup('chocolatey_version'),
    provider => 'chocolatey'
  }

}

[sheenaajay]

Hello @helge000 ,
Could you please resolve the conflicts and rebase it with the latest code version.
Thank you.

[helge000]

@sheenaajay - rebased. Hopefully this gets merged after 1.5 years...