(PUP-11947) Pin FFI to 1.15.5 #9112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FFI >= 1.16.0 breaks FFI modules in Facter, which is a dependency of Puppet. While the latest release of Facter (4.5.0) pins FFI to 1.15.5, Puppet's gemspec adds a Windows-specific runtime dependency on FFI set to > 1.9.24 < 2, which currently resolves to the latest version of FFI (1.16.2). This commit pins FFI to 1.15.5 to address the incompatibility between Facter and FFI >=1.16.0.
cthorn42
approved these changes
Sep 27, 2023
jordanbreen28
added a commit
to puppetlabs/puppet-editor-services
that referenced
this pull request
Sep 27, 2023
This change temporarily pins the ffi 1.15.2 gem and pulls this in to be used in CI for the editor-services. This change should be temporarily, to resolve failing CI until this bug is fixed upstream, and released in the next puppet platform release. See here puppetlabs/puppet#9112
jordanbreen28
added a commit
to puppetlabs/puppet-editor-services
that referenced
this pull request
Sep 27, 2023
This change temporarily pins the ffi 1.15.2 gem and pulls this in to be used in CI for the editor-services. This change should be temporarily, to resolve failing CI until this bug is fixed upstream, and released in the next puppet platform release. See here puppetlabs/puppet#9112
jordanbreen28
added a commit
to puppetlabs/puppet-editor-services
that referenced
this pull request
Sep 27, 2023
This change temporarily pins the ffi 1.15.2 gem and pulls this in to be used in CI for the editor-services. This change should be temporarily, to resolve failing CI until this bug is fixed upstream, and released in the next puppet platform release. See here puppetlabs/puppet#9112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FFI >= 1.16.0 breaks FFI modules in Facter, which is a dependency of Puppet. While the latest release of Facter (4.5.0) pins FFI to 1.15.5, Puppet's gemspec adds a Windows-specific runtime dependency on FFI set to > 1.9.24 < 2, which currently resolves to the latest version of FFI (1.16.2).
This commit pins FFI to 1.15.5 to address the incompatibility between Facter and FFI >=1.16.0.