(GH-46) Detect Puppet Environment correctly #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the puppet environment detection normally defaulted to root however this did not work correctly when the user running the language-server was non-root. This commit instead updates the environment detection to correctly find the puppet environment, and defaults to the previous behaviour if the new method failed to work.
glennsarti
force-pushed
the
gh-46-under-non-root
branch
from
a6ad428 to
6eb083b
Compare
jpogran
approved these changes
Jul 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the puppet environment detection normally defaulted to root however
this did not work correctly when the user running the language-server was
non-root. This commit instead updates the environment detection to correctly
find the puppet environment, and defaults to the previous behaviour if the new
method failed to work.
Fixes #46