Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-318 Used a realpath for load dependencies. #326

Merged
merged 5 commits into from
Feb 24, 2023

Conversation

bit0rez
Copy link
Contributor

@bit0rez bit0rez commented Jan 18, 2023

Solving a load depenencies bug.
Issue: #318

P.S.: Sorry if I'm doing something wrong. I'm not a Ruby developer and rarely commit in OpenSource projects.

@bit0rez bit0rez requested a review from a team as a code owner January 18, 2023 10:05
@CLAassistant
Copy link

CLAassistant commented Jan 18, 2023

CLA assistant check
All committers have signed the CLA.

@chelnak
Copy link
Contributor

chelnak commented Jan 18, 2023

@bit0rez this is pretty awesome. Thank you.

I've kicked the tests. Please can you sign the CLA while we wait for them to process?

@chelnak
Copy link
Contributor

chelnak commented Jan 18, 2023

Hmm looks like the test suite needs some love.

Leave it with us.

@bit0rez
Copy link
Contributor Author

bit0rez commented Jan 24, 2023

rubygems-update requires Ruby version >= 2.6.0. The current ruby version is 2.5.0.

The latest version of rubygems-update that requires Ruby version >= 2.3.0 is 3.3.26.
I think you need to fix setup script for tests that installs the latest version of packages at now.

@chelnak
Copy link
Contributor

chelnak commented Jan 24, 2023

Hello! I still haven't got round to looking at this but haven't forgotten. Had a few other priorities that needed my attention.

I'll take a look asap.

bit0rez and others added 2 commits January 31, 2023 16:48
Using the "latest" tag is a bad idea.
In this case images was updated and dependencies was broken.
@chelnak chelnak merged commit f0c7b45 into puppetlabs:main Feb 24, 2023
@bit0rez bit0rez deleted the GH-318-fix_languageserver_symlink branch February 25, 2023 08:34
@jordanbreen28 jordanbreen28 added the bug Something isn't working label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants