(GH-320) Handle @param tags for non-existent params #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Classes and defined types with docstring @param tags for parameters that are not actually present in the parameter list cause the language server to crash, due to populate_classes_from_yard_registry assuming param tags always have a :types array present. @param tags without types are now ignored. Note that class/defined type parameters without a specified type automatically have the "Any" type in their :types array, so they're not excluded by this change.
|
|
glennsarti
approved these changes
Jan 4, 2022
|
Cool, pleased to help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #320
Classes and defined types with docstring @param tags for parameters that are not actually present in the parameter list cause the language server to crash, due to
populate_classes_from_yard_registryassuming param tags always have a:typesarray present.@param tags without types are now ignored. Note that class/defined type parameters without a specified type automatically have the "Any" type in their :types array, so they're not excluded by this change.