(GH-245) Use object cache for fact data #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an acceptance test for the puppet/getFacts request. Previously this message was added to the message handler, but not to the test suite.
Previously the puppet/getFacts request would call out to Facter directly however this can be very slow, particularly with Facter v2 in the PDK. This commit changes the request to instead use the object cache which already has all of the available facter information. This commit also moves the method from the PuppetHelper to the FacterHelper where it would make more sense. This is tested as part of the acceptance suite.
Now that the language server no longer calls the facts_all action, the supporting code can be removed.
|
The primary reason I had not pulled from cache was that it means waiting for the language server to start and for the language server to run before querying, but I was able to set the promises in the client to wait. It works, and is slightly faster start because there isn't a second wait for the facts to be queried. So it all works with cached facts. However, hitting refresh doesn't 'refresh' anymore. It pulls from teh cache. How does a user get a 'fresh' run? |
jpogran
approved these changes
Apr 29, 2020
|
Created new issue to addressed refreshing facts. It is sufficient for the first version of this feature to simply have it refresh from cache |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #245
This commit adds an acceptance test for the puppet/getFacts request. Previously
this message was added to the message handler, but not to the test suite.
Previously the puppet/getFacts request would call out to Facter directly however
this can be very slow, particularly with Facter v2 in the PDK. This commit
changes the request to instead use the object cache which already has all of the
available facter information.
This commit also moves the method from the PuppetHelper to the FacterHelper
where it would make more sense. This is tested as part of the acceptance suite.
Now that the language server no longer calls the facts_all action, the
supporting code can be removed.