(GH-139) Provide completions for defined types #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the manifest completion provider would not provide results if the cursor was in a defined type. This commit adds the ResourceTypeDefinition much like the HostClassDefinition.
Previously the completion provider blindly moved the cursor one place back which worked fine if completions were triggered by a character instead of manual. Now that the LSP has provisions for the context of the completion request we can intelligently figure out when to remove the trigger character. This commit updates the mesasge handler to pass through the CompletionContext object and the completion provider can then determine how to use the context accordingly. This commit also updates the tests for this behaviour.
glennsarti
force-pushed
the
gh-139-nested-modules
branch
from
3bcdb03 to
13b8645
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #139
Previously the manifest completion provider would not provide results if the
cursor was in a defined type. This commit adds the ResourceTypeDefinition much
like the HostClassDefinition.
Previously the completion provider blindly moved the cursor one place back which
worked fine if completions were triggered by a character instead of manual.
Now that the LSP has provisions for the context of the completion request we
can intelligently figure out when to remove the trigger character.
This commit updates the mesasge handler to pass through the CompletionContext
object and the completion provider can then determine how to use the context
accordingly. This commit also updates the tests for this behaviour.