Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading of Puppet Types/Functions etc. should rescue errors and not crash #51

Closed
glennsarti opened this issue Aug 14, 2018 · 2 comments
Closed

Loading of Puppet Types/Functions etc. should rescue errors and not crash #51

glennsarti opened this issue Aug 14, 2018 · 2 comments
Milestone
0.15.0

Comments

@glennsarti
Copy link
Contributor

From - puppetlabs/puppet-vscode#349

What Versions are you running?

OS Version: N/A
VSCode Version: N/A
Puppet Extension Version: 0.11.0
Puppet Agent Version: N/A
PDK Version (if applicable): N/A

What You Are Seeing?

D, [2018-08-13T16:11:23.271452 #9328] DEBUG -- : [PUPPET LOG] [err] Could not autoload puppet/parser/functions/hiera.rb: cannot load such file -- hiera
E, [2018-08-13T16:11:23.273468 #9328] ERROR -- : [PuppetHelper::_load_default_functions] Error loading function puppet/parser/functions/hiera.rb: Could not autoload puppet/parser/functions/hiera.rb: cannot load such file --
 hiera ["C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in require'",
 "C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:inrequire'",
 "C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/vendor_ruby/hiera_puppet.rb:1:in <top (required)>'",
 "C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:inrequire'",
 "C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in require'",
 "C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/vendor_ruby/puppet/parser/functions/hiera.rb:1:in<top (required)>'",
 "C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/vendor_ruby/puppet/util/autoload.rb:68:in load'",
 "C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/vendor_ruby/puppet/util/autoload.rb:68:inload_file'",
 "C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/vendor_ruby/puppet/util/autoload.rb:194:in load'",
 "c:/Users/mchen6/My Programs/VS Code/data/extensions/jpogran.puppet-vscode-0.11.0/vendor/languageserver/lib/puppet-languageserver/puppet_helper.rb:364:inload_function_file'",
 "c:/Users/mchen6/My Programs/VS Code/data/extensions/jpogran.puppet-vscode-0.11.0/vendor/languageserver/lib/puppet-languageserver/puppet_helper.rb:424:in block in _load_default_functions'",
 "c:/Users/mchen6/My Programs/VS Code/data/extensions/jpogran.puppet-vscode-0.11.0/vendor/languageserver/lib/puppet-languageserver/puppet_helper.rb:421:ineach'",
 "c:/Users/mchen6/My Programs/VS Code/data/extensions/jpogran.puppet-vscode-0.11.0/vendor/languageserver/lib/puppet-languageserver/puppet_helper.rb:421:in _load_default_functions'",
 "c:/Users/mchen6/My Programs/VS Code/data/extensions/jpogran.puppet-vscode-0.11.0/vendor/languageserver/lib/puppet-languageserver/puppet_helper.rb:71:inload_functions'",
 "c:/Users/mchen6/My Programs/VS Code/data/extensions/jpogran.puppet-vscode-0.11.0/vendor/languageserver/lib/puppet-languageserver/puppet_helper.rb:76:in `block in load_functions_async'"]

What is Expected?

It shouldn't crash

How Did You Get This To Happen? (Steps to Reproduce)

Output Log
@glennsarti glennsarti mentioned this issue Aug 14, 2018
Closed
@glennsarti
Copy link
Contributor Author

e.g. https://github.com/lingua-pupuli/puppet-editor-services/blob/6eb083bd9aa11f3473c3fd97764edfd8ab6429aa/lib/puppet-languageserver/puppet_helper.rb#L377

glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Aug 30, 2018
@glennsarti
(puppetlabsGH-51) Add handling of errors when loading classes
ec518ae 
Previously if there was an error while parsing classes, it would cascade the
error and crash the sidecar.  This commit catches the error and gracefully
continues.
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Aug 31, 2018
@glennsarti
(puppetlabsGH-51) Add handling of errors when loading classes
2721ac1 
Previously if there was an error while parsing classes, it would cascade the
error and crash the sidecar.  This commit catches the error and gracefully
continues.
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Aug 31, 2018
@glennsarti
(puppetlabsGH-51) Add handling of errors when loading classes
8b2366b 
Previously if there was an error while parsing classes, it would cascade the
error and crash the sidecar.  This commit catches the error and gracefully
continues.
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Sep 27, 2018
@glennsarti
(puppetlabsGH-51) Add handling of errors when loading classes
4f87e4e 
Previously if there was an error while parsing classes, it would cascade the
error and crash the sidecar.  This commit catches the error and gracefully
continues.
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Sep 27, 2018
@glennsarti
(puppetlabsGH-51) Add handling of errors when loading classes
1875e56 
Previously if there was an error while parsing classes, it would cascade the
error and crash the sidecar.  This commit catches the error and gracefully
continues.
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Oct 2, 2018
@glennsarti
(puppetlabsGH-51) Add handling of errors when loading classes
61c728c 
Previously if there was an error while parsing classes, it would cascade the
error and crash the sidecar.  This commit catches the error and gracefully
continues.
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Oct 3, 2018
@glennsarti
(puppetlabsGH-51) Add handling of errors when loading classes
c1e4995 
Previously if there was an error while parsing classes, it would cascade the
error and crash the sidecar.  This commit catches the error and gracefully
continues.
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Oct 3, 2018
@glennsarti
(puppetlabsGH-51) Add handling of errors when loading classes
5f0d0cb 
Previously if there was an error while parsing classes, it would cascade the
error and crash the sidecar.  This commit catches the error and gracefully
continues.
@glennsarti glennsarti added this to the 0.15.0 milestone Oct 17, 2018
@glennsarti
Copy link
Contributor Author

Merged as part of sidecar. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
1 participant
@glennsarti