Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FIXUP) Add a GEM_PATH for bundler when running acceptance tests #80

Merged
merged 1 commit into from
Jun 15, 2017

Conversation

scotje
Copy link
Contributor

@scotje scotje commented Jun 14, 2017

I had to do this to get acceptance tests running in my environment, opening the PR to see if it passes Travis/Appveyor.

Copy link
Contributor

@rodjek rodjek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Change works on my machine

@james-stocks
Copy link

@scotje for reference; do you have a copy of the error/problem this fixes?
I was seeing issues with bundler in the acceptance tests.

@DavidS DavidS merged commit 5782625 into puppetlabs:master Jun 15, 2017
@scotje
Copy link
Contributor Author

scotje commented Jun 15, 2017

@james-stocks when pdk tried to require "bundler" during acceptance tests, it would produce this error output:

[???] Resolving Gemfile dependencies
       +
       +/Users/jesse/.rbenv/versions/2.1.9/lib/ruby/2.1.0/rubygems/dependency.rb:298:in `to_specs': Could not find 'bundler' (>= 0) among 146 total gem(s) (Gem::LoadError)
       +        from /Users/jesse/.rbenv/versions/2.1.9/lib/ruby/2.1.0/rubygems/dependency.rb:309:in `to_spec'
       +        from /Users/jesse/.rbenv/versions/2.1.9/lib/ruby/2.1.0/rubygems/core_ext/kernel_gem.rb:53:in `gem'
       +        from /Users/jesse/.rbenv/versions/2.1.9/bin/bundle:22:in `<main>'

Edit: Actually, looking at the stacktrace it looks like it was the bundle executable itself which couldn't find bundler.

@chelnak chelnak added the maintenance Internal maintenance work that shouldn't appear in the changelog label Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Internal maintenance work that shouldn't appear in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants