(SDK-197) add acceptance tests for new class command #65
Conversation
Surely these will be broken on non-linux, but I need to get it off this workstation.
spec/acceptance/new_class_spec.rb
Outdated
| end | ||
|
|
||
| context 'when creating the main class' do | ||
| describe command("cd foo && BUNDLE_GEMFILE=../Gemfile #{path_to_pdk} new class foo") do |
There was a problem hiding this comment.
@scotje 's work here might help with this:
https://github.com/puppetlabs/pdk/pull/62/files#diff-174f7dfb508155027cb4c3e9a1840591R28
There was a problem hiding this comment.
I assume you meant @scotje ?
Yeah binstubs look like a good way out here - I'll try that. It might also help with the bundle/rvm fighting we ran into yesterday...
There was a problem hiding this comment.
I assume you meant @scotje ?
I assume so too :-) ... looks exciting thought.
There was a problem hiding this comment.
I think the binstubs do work on windows as well, you just have to explicitly run them with the ruby interpreter, so ruby /path/to/binstub/pdk <args>
|
I've changed the pdk path for local acceptance tests so that we generate and use the binstub instead of |
rodjek
force-pushed
the
sdk-197-add-acceptance-tests
branch
3 times, most recently
from
df8ab5c to
f83124d
Compare
rodjek
force-pushed
the
sdk-197-add-acceptance-tests
branch
from
f83124d to
99a99dd
Compare
DavidS
changed the title
chelnak
added
the
maintenance
Surely these will be broken on non-linux, but I need to get it off this
workstation.