(maint) Fix package tests to remove hardcoding #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ran the package tests changes against SHA "ea596e938f28de92f884e2abfd1356256641cd66" on redhat7 and windows2012. |
The vendored Gemfile name had a hardcoded value with the "latest ruby" version. This caused breakage in package tests each time packaged ruby versions were updated. This fix updates the tests to detect the latest version from the pdk private cache.
chelnak
added
the
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vendored Gemfile name had a hardcoded value with the "latest ruby"
version. This caused breakage in package tests each time packaged ruby
versions were updated. This fix updates the tests to detect the latest version
from the pdk private cache.