Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MAINT) Fix package acceptance tests to pass with any Ruby 2.4.x #611

Merged
merged 3 commits into from
Jan 7, 2019

Conversation

scotje
Copy link
Contributor

@scotje scotje commented Jan 4, 2019

Loosens the version check for Puppet's that map to Ruby 2.4.x

@scotje scotje requested a review from rodjek January 4, 2019 00:56
@coveralls
Copy link

coveralls commented Jan 4, 2019

Coverage Status

Coverage remained the same at 92.988% when pulling 6a413ef on scotje:maint_fix_package_tests_ruby_245 into 24ff96b on puppetlabs:master.

scotje added 2 commits January 4, 2019 11:52
- Updates the bundler dependency in pdk.gemspec to allow 2.x versions
- Pins bundler to 1.17.3 for Ruby 2.1.9 in Travis config
@scotje scotje force-pushed the maint_fix_package_tests_ruby_245 branch from bf326ea to cd5ea54 Compare January 4, 2019 19:52
@rodjek rodjek merged commit 1fb549a into puppetlabs:master Jan 7, 2019
@rodjek rodjek mentioned this pull request Jan 7, 2019
@chelnak chelnak added the maintenance Internal maintenance work that shouldn't appear in the changelog label Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Internal maintenance work that shouldn't appear in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants