Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Fix package tests #596

Merged
merged 3 commits into from
Nov 21, 2018
Merged

Conversation

rodjek
Copy link
Contributor

@rodjek rodjek commented Nov 20, 2018

  • PDK now lays down a Gemfile.lock when initialising a module, so we can't expect it to be absent.
  • Remove the DEPENDENCIES section of the Gemfile.lock before comparing. This section only lists the specified depedencies whereas the GEMS section is more important as it contains all the fully resolved dependencies. The DEPENDENCIES section can cause false failures in cases where different ways of specifying the dependency resolve to the same version e.g. puppet (~> 6.0) != puppet (= 6.0.4) even though they resolve to the same version.
  • Either the SUITE_VERSION env var changed for OSX or the path vanagon creates changed since the last release. In any case, the path to the .pkg in the .dmg has changed and we need to update our OSX package install logic.

@coveralls
Copy link

coveralls commented Nov 20, 2018

Coverage Status

Coverage remained the same at 92.994% when pulling 547e816 on rodjek:fix-package-tests into d4d1c9d on puppetlabs:master.

@rodjek
Copy link
Contributor Author

rodjek commented Nov 21, 2018

@scotje scotje merged commit 387ff02 into puppetlabs:master Nov 21, 2018
@rodjek rodjek deleted the fix-package-tests branch November 21, 2018 00:38
@chelnak chelnak added the maintenance Internal maintenance work that shouldn't appear in the changelog label Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Internal maintenance work that shouldn't appear in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants