(maint) update: don't mention deleted Gemfile.lock and .bundle/config #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when running pdk update, note how in the second case there were "2 files removed": ``` david@davids:~/git/tmp/bar$ rm -f .travis.yml; ~/git/pdk/bin/pdk update --force pdk (INFO): Updating david-bar using the template at file:///opt/puppetlabs/pdk/share/cache/pdk-templates.git, from 1.4.1 to master@52adbbb ------------Files to be added----------- .travis.yml ---------------------------------------- ------------Update completed------------ 1 files added. david@davids:~/git/tmp/bar$ rm -f Gemfile ; ~/git/pdk/bin/pdk update --force pdk (INFO): Updating david-bar using the template at file:///opt/puppetlabs/pdk/share/cache/pdk-templates.git, from 1.4.1 to master@52adbbb ------------Files to be added----------- Gemfile ---------------------------------------- [✔] Resolving Gemfile dependencies. ------------Update completed------------ 1 files added, 2 files removed. david@davids:~/git/tmp/bar$ ``` Since the files are not mentioned in the report, this could be very confusing to users. With this patch, the files are still removed, but the summary doesn't show them any more: ``` david@davids:~/git/tmp/bar$ rm -f Gemfile ; ~/git/pdk/bin/pdk update --force pdk (INFO): Updating david-bar using the template at file:///opt/puppetlabs/pdk/share/cache/pdk-templates.git, from 1.4.1 to master@52adbbb ------------Files to be added----------- Gemfile ---------------------------------------- [✔] Resolving Gemfile dependencies. ------------Update completed------------ 1 files added. david@davids:~/git/tmp/bar$ ```
chelnak
added
the
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when running pdk update, note how in the second case there were "2 files removed":
Since the files are not mentioned in the report, this could be very
confusing to users. With this patch, the files are still removed, but
the summary doesn't show them any more: