Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(maint) Fix generate/ and validate/ file layout to match namespace #345

Merged
merged 2 commits into from
Nov 10, 2017
Merged

(maint) Fix generate/ and validate/ file layout to match namespace #345

merged 2 commits into from
Nov 10, 2017

Conversation

rodjek
Copy link
Contributor

@rodjek rodjek commented Nov 9, 2017

Moves the lib/pdk/generators/ and lib/pdk/validators/ files to lib/pdk/generate/ and lib/pdk/validate respectively in order to match the namespaces of the code in the files.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.428% when pulling d00348e on rodjek:namespace_cleanup into acc5897 on puppetlabs:master.

bmjen
bmjen approved these changes Nov 9, 2017
View reviewed changes
Copy link
Contributor

@bmjen bmjen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.456% when pulling 75f089b on rodjek:namespace_cleanup into 4413f5b on puppetlabs:master.

@bmjen bmjen merged commit fe340a8 into puppetlabs:master Nov 10, 2017
@rodjek rodjek deleted the namespace_cleanup branch November 10, 2017 00:29
@chelnak chelnak added the maintenance Internal maintenance work that shouldn't appear in the changelog label Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmjen bmjen bmjen approved these changes

Assignees
No one assigned
Labels
maintenance Internal maintenance work that shouldn't appear in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rodjek @coveralls @bmjen @chelnak