Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(SDK-313) Update acceptance tests following audit #193

Merged
merged 5 commits into from
Aug 8, 2017
Merged

(SDK-313) Update acceptance tests following audit #193

merged 5 commits into from
Aug 8, 2017

Conversation

james-stocks
Copy link

Following an audit of the current acceptance tests; there are a number that are acceptable to test at the unit test level.

@james-stocks
Copy link
Author

I can probably squash to a single commit; but I thought separate commits might make it easier to review and follow up on feedback for changes

@scotje
Copy link
Contributor

scotje commented Jul 25, 2017

Rebased

@DavidS
Copy link
Contributor

DavidS commented Jul 26, 2017

The new tests are not very unit-y. Are they at least faster?
We can pair tomorrow afternoon for a more in-depth transformation.

@james-stocks james-stocks force-pushed the SDK-313 branch 3 times, most recently from be28ddd to ce57bad Compare July 31, 2017 09:46
james-stocks and others added 4 commits August 8, 2017 09:19
(SDK-313) Move audited acceptance tests to unit tests
a0878cc
(SDK-313) Replace acceptance/test_spec.rb with a unit test
5c25d81
(SDK-313) Refine validation acceptance tests
e78e865 
Remove tests that are either:
 * Sufficiently covered at the unit test level, or
 * Are 'happy path' tests that are redundant on the negative test cases that accompany them
@DavidS
(maint) Increase unit coverage for test and test unit
269321c
@coveralls
Copy link

Coverage Status

Coverage increased (+1.5%) to 92.256% when pulling 269321c on james-stocks:SDK-313 into 44929d8 on puppetlabs:master.

@puppetlabs puppetlabs deleted a comment from coveralls Aug 8, 2017
@puppetlabs puppetlabs deleted a comment from coveralls Aug 8, 2017
@puppetlabs puppetlabs deleted a comment from coveralls Aug 8, 2017
@DavidS
Copy link
Contributor

DavidS commented Aug 8, 2017

oops, I should have rebased this before pushing

@DavidS
(SDK-313) refactor cli/tests/unit_spec.rb
bb2c170 
* extract common pre-conditions
* change SystemExit to detect missing exceptions
* move explicit $stdout expectations to output matchers
DavidS
DavidS approved these changes Aug 8, 2017
View reviewed changes
Copy link
Contributor

@DavidS DavidS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, pending confirmation of travis.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.5%) to 92.23% when pulling 2dfc9a1 on james-stocks:SDK-313 into 264f3cc on puppetlabs:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.5%) to 92.23% when pulling bb2c170 on james-stocks:SDK-313 into 5b925f0 on puppetlabs:master.

@DavidS DavidS merged commit 916ae59 into puppetlabs:master Aug 8, 2017
@DavidS DavidS deleted the SDK-313 branch August 8, 2017 16:23
@chelnak chelnak added the maintenance Internal maintenance work that shouldn't appear in the changelog label Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scotje scotje scotje approved these changes

@DavidS DavidS DavidS approved these changes

@rodjek rodjek Awaiting requested review from rodjek

@bmjen bmjen Awaiting requested review from bmjen

Assignees
No one assigned
Labels
maintenance Internal maintenance work that shouldn't appear in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@james-stocks @scotje @DavidS @coveralls @chelnak