(maint) Finish PDK::Validate::* unit tests #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodjek
force-pushed
the
validator_unit_tests
branch
from
655c07c to
799f753
Compare
rodjek
changed the title
bmjen
reviewed
Jul 13, 2017
lib/pdk/validators/ruby/rubocop.rb
Outdated
| @@ -16,6 +16,10 @@ def self.cmd | |||
| 'rubocop' | |||
| end | |||
|
|
|||
| def self.pattern | |||
| ['**/*.rb'] | |||
There was a problem hiding this comment.
I recall we had a brief discussion about how rubocop should lint anything that has ruby in it, including Gemfile and Rakefile. Adding a pattern will ignore those files now, is that desired behavior?
There was a problem hiding this comment.
That's a good point (although our .rubocop.yml template in puppetlabs/pdk-module-template is explicitly excluding Gemfile and Rakefile at the moment, but we can fix that later). I'll remove the pattern and update the spec
rodjek
force-pushed
the
validator_unit_tests
branch
from
9b4a5a7 to
f9c11db
Compare
rodjek
force-pushed
the
validator_unit_tests
branch
from
f9c11db to
7f166b9
Compare
chelnak
added
the
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.