Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Support for skipped/pending tests #115

Merged
merged 1 commit into from
Jun 28, 2017

Conversation

james-stocks
Copy link

Documents that skipped tests will include rspec pending examples.
Adds skipped tests to our XML reports
Updates the test fixture XML schema to allow for skipped tests

Documents that skipped tests will include rspec pending examples.
Adds skipped tests to our XML reports
Updates the test fixture XML schema to allow for skipped tests
@james-stocks james-stocks requested review from scotje, DavidS and rodjek June 28, 2017 09:31
@rodjek
Copy link
Contributor

rodjek commented Jun 28, 2017

This seems like a good change to me. This schema (without these changes) is the same one used by the most popular rspec plugin as a reference. That plugin also uses the skipped element, so I guess it doesn't pass the XSD validation either 😆. Despite that, I don't see any issues on that repo where the skipped element is causing any problems, so i'm 👍 to adding it to the XSD.

@DavidS
Copy link
Contributor

DavidS commented Jun 28, 2017

Some more spelunking. The current XMLJUnitFormatter code from ANT: https://git-wip-us.apache.org/repos/asf?p=ant.git;a=blob;f=src/main/org/apache/tools/ant/taskdefs/optional/junit/XMLJUnitResultFormatter.java;h=d62a847d490b3b3acbe8fa0ace23a104081c5679;hb=HEAD ; a community contributed XSD for junit4's output: https://gist.github.com/kuzuha/232902acab1344d6b578 ;

I wasn't able to locate the junit-plugins actual parsing code in https://github.com/jenkinsci/junit-plugin/, but there is ample material referencing the "skipped" properties

@DavidS DavidS merged commit e8133cb into puppetlabs:master Jun 28, 2017
@chelnak chelnak added the maintenance Internal maintenance work that shouldn't appear in the changelog label Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Internal maintenance work that shouldn't appear in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants