Create Github Workflow for Static & Spec Tests

[sanfrancrisko]

Create a Github Workflow for the PR Tests that will cover:

On a hosted runner:

• For each Ruby version (2.5, 2.7):
  • rubocop
  • spec:coverage
  • license_finder
  • test_pdk_as_library
  • spec

[jpogran]

We should target windows-latest and ubuntu-latest in hosted as a early warning system.

For acceptance testing, there is little difference (for our purposes) between 2016 and 2019, so we can limit to just that version and simplify things. For bonus points we could add a recent Windows 10 to test a desktop scenario, but I'm not sure what GCP images we have available.

I'm less certain about linux, I will check analytics but I think our most popular there is RHEL. I think ubuntu 20.04 should be good for the moment, and we should add as we get more info.

[sanfrancrisko]

Sounds good. We'll go for parity with what we have at the moment, by the sounds of it.

I'll also update the description to plug in to Honeycomb with metrics.

Regarding Windows 10 (or any desktop Windows flavour), it seems to be missing from GCP's list of available images. The provision_service will be gaining support for AWS and Azure at some stage in the future, so I suspect the path of least resistance is to wait until that implementation and then add it in for ourselves.

[jpogran]

Updated ticket description with target implementation

[sanfrancrisko]

An additional piece of work spurred from this was to refactor the validator in the provision_service to allow the pdk repo to provision resources in GCP.

See: https://github.com/puppetlabs/provision_service/pull/280

[sanfrancrisko]

Given the complexities discovered during implementation for the Acceptance Test workflows, I'll raise separate tickets to cover:

• Acceptance tests on Linux (Hosted Runner on Github)
• Acceptance tests on Windows (GCP provisioned image via provision_service - see https://github.com/puppetlabs/provision_service/pull/283)